Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech/3483/integrate kotter #3609

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Tech/3483/integrate kotter #3609

wants to merge 26 commits into from

Conversation

Nereboss
Copy link
Collaborator

@Nereboss Nereboss commented May 6, 2024

Rebuild functionality of the no longer supported KotlinInquirer using Kotter

Issue: #3483

Description

Use the Kotter library to rebuild the functionality of the KolinInquirer Library. It is currently used for the interactive CLI interface but is no longer supported.
Using our own questions built with kotter gives us more control over the interactive questions and allows for features like auto completion.
This also integrates the new kotter methods into the StructureModifier.

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

Nereboss and others added 25 commits May 6, 2024 13:27
Class is no longer needed as all functions extend the Session class from Kotter and are applicable in the correct scope
Still a lot of todos that need to be closed and comments that need to be implemented, as well as finding a solution for the session problem
@phanlezz phanlezz force-pushed the tech/3483/integrate-kotter branch from 6282905 to 11807b5 Compare May 6, 2024 13:23
@phanlezz
Copy link
Collaborator

phanlezz commented May 6, 2024

I rebased the changes on-top of the current main branch.

Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Visualization'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Nereboss
Copy link
Collaborator Author

This is blocked by flaky tests that we think are caused by a bug in kotters testing library (we created an issue for that: varabyte/kotter#114)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants