Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul the Suspicious Metrics menu with Angular-17 #3612

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

ViktoriaGordeevaVG
Copy link
Collaborator

@ViktoriaGordeevaVG ViktoriaGordeevaVG commented May 8, 2024

Overhaul the Suspicious Metrics menu

Closes: #3493

Description

The 'Suspicious Metrics' tab has been streamlined and is now more user-friendly. Key improvements include:

  • Information about suspicious metrics is neatly concealed within an info box, accessible via click or hover for easy visibility.
  • Untracked metrics in the code are now neatly tucked away in a toggle feature, which can be expanded with a click, similar to the functionality of our file explorer.

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

@ViktoriaGordeevaVG ViktoriaGordeevaVG changed the title 3493 updated angular-17 Overhaul the Suspicious Metrics menu May 8, 2024
@ViktoriaGordeevaVG ViktoriaGordeevaVG changed the title Overhaul the Suspicious Metrics menu Overhaul the Suspicious Metrics menu with Angular-17 May 8, 2024
@ChristianHuehn
Copy link
Collaborator

ChristianHuehn commented May 10, 2024

image

We should probably improve a couple of things:

  • Make Suspicious Metrics at the top a bit bigger so that it's a heading for the whole Metrics part
  • reduce space between "Suspicious Metrics" and "Suspicious Metrics in ts code"
  • if easily achievable, animate the arrow from accordions
  • reduce space between accordions to their content like "Unsuspcious metrics in ts code"
  • remove one level of idention of unsuspicious and untracked metricks so it feels like the following example:

Suspicious Metrics (h1)
Suspicious Metrics in ts code (h2 - identation 0)
Unsuspicious metrics in ts code (h2 - identation from 1 to 0)
Untracked metrics in ts code (h2 - identation from 1 to 0)

h1 and h2 are just examples. Use an appropriate level so that h1 feels like a header and h2 like headers for categories inside. 👍

@phanlezz phanlezz force-pushed the feature/3493/overhaul-suspicious-metrics-menu-a17 branch from b07c10d to 034b840 Compare May 27, 2024 08:32
@phanlezz phanlezz force-pushed the feature/3493/overhaul-suspicious-metrics-menu-a17 branch from c9baf98 to 6e12e94 Compare May 29, 2024 07:44
@phanlezz phanlezz requested a review from Nereboss May 29, 2024 07:46
Copy link

sonarcloud bot commented May 29, 2024

Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Analysis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overhaul the Suspicious Metrics menu
3 participants