Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 3MF export for multi-color 3D printing of maps #3616

Closed
wants to merge 91 commits into from

Conversation

olexs
Copy link
Collaborator

@olexs olexs commented May 14, 2024

Implement 3MF export for multi-color 3D printing of maps

Description

This PR implements a 3MF export in addition to the already existing STL export. This allows to print CodeCharta maps on multi-material printers like the BambuLabs machines or the Prusa XL in multiple colors.

Additionally, the printed map now includes a MW logo, a custom text line, an optional project logo, and a reverse side with a legend of included metrics and their values.

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots

Screenshot 2024-05-14 at 17 17 58

IMG_0331
IMG_0325

@phanlezz
Copy link
Collaborator

It looks like the sonar token is no available or set correctly in forks. Any idea how to resolve this? Maybe you can reopen this as a PR directly in the repository? @olexs

@olexs
Copy link
Collaborator Author

olexs commented May 17, 2024

Ideally we should reconfigure the workflow, so that Sonar is not ran for PRs from forks - as you say, the token is not available in forks, since it's a (secret) project variable that could otherwise be leaked to a modified workflow in a fork.

If we want Sonar to run on all PRs, I could re-make this as a branch from the main repo, since I have contributor access.

@phanlezz
Copy link
Collaborator

Ideally we should reconfigure the workflow, so that Sonar is not ran for PRs from forks - as you say, the token is not available in forks, since it's a (secret) project variable that could otherwise be leaked to a modified workflow in a fork.

But if sonar is not active on forks, we can't really merge them, because the code quality can not be verified?

If we want Sonar to run on all PRs, I could re-make this as a branch from the main repo, since I have contributor access.

I would appreciate it, because it is the easiest/fastest way to get this awesome feature on main 🚀

@olexs
Copy link
Collaborator Author

olexs commented May 18, 2024

I would appreciate it, because it is the easiest/fastest way to get this awesome feature on main 🚀

It appears I do not have write permissions to the main repo after all, so I can't push the branch directly, only via my fork right now. How do we best go about this?

@phanlezz
Copy link
Collaborator

I could add you as a maintainer or similar to the repository, then you could open a branch and PR with all those changes, and we can review and merge it.
Should I add @olexs ?
(I don't know if it is possible to move your changes from fork:main to origin:another-branch, so you might need to copy the changes via a soft reset)

@olexs
Copy link
Collaborator Author

olexs commented May 19, 2024

Yes, if it's ok please add me. I have already figured out the branch stuff, just need the permission to push. Thanks!

@phanlezz
Copy link
Collaborator

Yes, if it's ok please add me. I have already figured out the branch stuff, just need the permission to push. Thanks!

I added you with 'Write', ping me if it is not enough.

@olexs
Copy link
Collaborator Author

olexs commented May 19, 2024

Thanks, looks like it worked. I'm closing this, new PR is #3630.

@olexs olexs closed this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants