Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: promote to moderator instead of transferring moderator role #233

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat: promote to moderator instead of transferring moderator role #233

wants to merge 2 commits into from

Conversation

dostulataa
Copy link
Collaborator

@dostulataa dostulataa commented Jan 10, 2024 •
edited

Allow multiple moderators for a room

Please read the CONTRIBUTING.md before opening a PR.

Issue: #195

Description

Descriptive pull request text, answering:

  • What problem/issue are you fixing? every user can be a moderator at the same time
  • What does this PR implement and how? promoting a user to moderator does not remove the promoter's moderator role

@dostulataa dostulataa self-assigned this Jan 10, 2024
NearW
NearW approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@NearW NearW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dostulataa
Copy link
Collaborator Author

This still has a bug and stays a draft until fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NearW NearW NearW approved these changes

@xWorkerBeex xWorkerBeex Awaiting requested review from xWorkerBeex

Assignees

@dostulataa dostulataa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dostulataa @NearW