Merge from upstream #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #525
This is the browser used by Meta's Quest line of headsets
…gents like "Java/1.8.0_362"
Add PetalBot
Add Oculus Browser
Add iOS 16
Parse modern Java versions
Fix Firefox regex to handle version without patch segment
Add regex for the PingdomPageSpeed bot
chore(actions): upgrade to checkout@v3
With how the regex was written before, it was matching either Phantom/ios or android, instead of Phantom/android. The test worked as expected, but this broke the newly introduced test for Ecosia, as it would match aswell.
Add Ecosia support & fix Phantom regex
feat: add support for MullvadBrowser
The UA for Edge on iPad OS doesn't specify the full edge version, but only the major. This changes the regex so that both minor & patch versions are optional.
fix: parse Edge on iPad OS properly
The UA for Chrome on iOS doesn't specify the full Chrome version, but only the major. This changes the regex so that both minor & patch versions are optional.
Before this change, the Nintendo Switch UA wasn't being fully parsed, so the OS was considered to be "Other", which is the default value. This fixes it, by updating the Nintendo regex to handle it properly.
Also removes SamsungBrowser from the Meta Quest tests as this is no longer part of the UA Co-authored-by: geoada <geoada@fb.com>
* update yandex browser regex * Update test_ua.yaml * fix yandex browser test --------- Co-authored-by: Carlos Azevedo <cazevedo@cloudflare.com> Co-authored-by: Louis <lbarthonet@cloudflare.com>
…575) Co-authored-by: Carlos Azevedo <cazevedo@cloudflare.com>
* fix: update Brave Browser regex * fix brave browser regex --------- Co-authored-by: Carlos Azevedo <cazevedo@cloudflare.com>
* update vivaldi browser regex to match multiple versioning structures * feat: add Huawei Browser * feat: add AVG * feat: add Avast Secure Browser * feat: add Instabridge browser * feat: add Aloha Browser * fix AVG browser test * fix: remove unnecessary capturing group --------- Co-authored-by: Carlos Azevedo <cazevedo@cloudflare.com>
`patch_minor` was added to regexes and some test_ua entries in #322. Neither spec nor reference implementation were ever updated for it, so many regexes were merged (?) with a capture for `patch_minor` but without correctly asserting it, and a pair of cases specify a `patch_minor` which is not captured: - the facebook regex[^1] only has 4 capturing groups - same for the AWS regex[^2] [^1]: https://github.com/ua-parser/uap-core/blob/959e106754828ae557b0dbcfaf8eeee938d3c824/regexes.yaml#L176 [^2]: https://github.com/ua-parser/uap-core/blob/959e106754828ae557b0dbcfaf8eeee938d3c824/regexes.yaml#L155
…de on The desktop mode on both those applications changes the user-agent, making it say that the device runs Mac OS X. However, this still runs on iOS, and should be parsed as is.
This is supported by the JS library, but not by all the others. This sets the model to Chromecast, to prevent any possible error going on, as the model is needed in that regex.
fix(device): ensure chromecast parsing doesn't return null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.