-
-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow PROXY_PROTOCOL to be per-port customizable. #3061
Conversation
Thanks for submitting this pull request. bors try Note: if this build fails, read this. |
tryBuild succeeded: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is something we want (in general): without documentation it's worthless and making good documentation about it is complex.
I also fail to see why we wouldn't go the extra mile and allow PROXY_PROTOCOL to be a comma separated list of ports we'd allow if we go down that route.
* ``pop3`` to accept the ``PROXY`` protocol on TCP 110 only | ||
* ``submissions`` to accept the ``PROXY`` protocol on TCP 465 only | ||
* ``submission`` to accept the ``PROXY`` protocol on TCP 587 only | ||
* ``smtp`` to accept the ``PROXY`` protocol on TCP 995 only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* ``smtp`` to accept the ``PROXY`` protocol on TCP 995 only | |
* ``pop3s`` to accept the ``PROXY`` protocol on TCP 995 only |
#3060 was asking for something similar |
Thanks for submitting this pull request. bors try Note: if this build fails, read this. |
tryBuild succeeded: |
What type of PR?
Enhancement
What does this PR do?
Allow
PROXY_PROTOCOL
env variable to be set on only a specific port. Eg, in my case, only tcp/25 needs to have PROXY_PROTOCOL enabled.Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.