-
-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Belarusian translation. #3207
Conversation
Thanks for submitting this pull request. bors try Note: if this build fails, read this. |
tryBuild succeeded: |
Ok, now I think it is finally ready and correct. Please review. |
bors try |
tryBuild succeeded: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. Can you also add a translation for the text string Current password
?
Mailu/core/admin/mailu/ui/forms.py
Line 134 in efb3892
current_pw = fields.PasswordField(_('Current password'), [validators.DataRequired()]) |
https://github.com/Mailu/Mailu/blob/master/core/admin/mailu/ui/templates/user/password.html
This text string is shown on the password update page. The URL for accessing this page is:
https://myhostname.com/myuser(thelocalpart)/user/password
E.g. if your login is example@mailu.io
and the hostname is mailu.io
:
https://mailu.io/example/user/password
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same applies for the text string Download zonefile
</a><a style="margin-right: 5px;" class="btn btn-primary btn-group float-right" href="{{ url_for(".domain_download_zonefile", domain_name=domain.name) }}"> {% trans %}Download zonefile{% endtrans %}</a> |
This string is used on the Domain details page:
https://example.com/admin/domain/details/mailu.io
where mailu.io is the mail domain
Both untranslated text strings are new in the upcoming release and have not been translated yet in any of the other languages. That is why you missed these. |
On the user edit page (https://example.com/admin/user/edit/admin@mailu.io) you are also missing the translations for:
You can translate the earlier mentioned missing translations via:
|
Ok, tried to add them. Also added translation for a note about Apple autoconfig. Not sure how to get an image to test it all - do I need to post Anyways, @Diman0 please take another look. |
You are correct. Only maintainers can trigger a build. You can test the new build using tag pr-3207 Bors try |
tryBuild succeeded: |
@Diman0 I verified it, everything looks good. |
Thank you for the confirmation. It also looks good to me. At least that the interface is translated to a different language than English. I don't speak Belarusian so I trust the translation is correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bors r+ |
Build succeeded: |
What type of PR?
Translation.
What does this PR do?
Adds Belarusian translation.
Related issue(s)
Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.