Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify the logic, add an extra check on the API auth handler #3232

Merged
merged 3 commits into from
Jun 9, 2024

Conversation

nextgens
Copy link
Contributor

@nextgens nextgens commented Apr 18, 2024

What type of PR?

enhancement

What does this PR do?

simplify the logic of API authentication, ensure that the API token is at least 3 characters

Related issue(s)

Prerequisites

Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

  • In case of feature or enhancement: documentation updated accordingly
  • Unless it's docs or a minor change: add changelog entry file.

Copy link
Contributor

mergify bot commented Apr 18, 2024

Thanks for submitting this pull request.
Bors-ng will now build test images. When it succeeds, we will continue to review and test your PR.

bors try

Note: if this build fails, read this.

bors-mailu bot added a commit that referenced this pull request Apr 18, 2024
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Apr 18, 2024

try

Build failed:

@nextgens
Copy link
Contributor Author

bors retry

bors-mailu bot added a commit that referenced this pull request Apr 18, 2024
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Apr 18, 2024

try

Build succeeded:

@nextgens nextgens changed the title simplify the logic simplify the logic, add an extra check on the API auth handler Apr 20, 2024
@nextgens nextgens added type/security Related to security and removed type/security Related to security labels Apr 20, 2024
@nextgens nextgens added this to the 2024.x milestone Apr 20, 2024
@nextgens
Copy link
Contributor Author

bors retry

bors-mailu bot added a commit that referenced this pull request Apr 20, 2024
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Apr 20, 2024

try

Build succeeded:

Copy link
Member

@Diman0 Diman0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

mergify bot commented Jun 9, 2024

bors r+

@bors-mailu
Copy link
Contributor

bors-mailu bot commented Jun 9, 2024

Build succeeded:

@bors-mailu bors-mailu bot merged commit c18eb3a into Mailu:master Jun 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants