-
-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #3252 #3254
base: master
Are you sure you want to change the base?
fix #3252 #3254
Conversation
Thanks for submitting this pull request. bors try Note: if this build fails, read this. |
We should probably have tests for 'exotic'/invalid addresses ; I am not sure how to test this properly; creating a new domain will exercise different code paths from what a remote delivery would be. Thoughts? |
tryBuild succeeded: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for approving it but it's just not ready. Let's discuss on #mailu-dev |
What type of PR?
bug-fix
What does this PR do?
Ensure that sending emails to invalid addresses with an '@' in localpart is permanently and not temporarily rejected.
This is the sister commit of 15569c6
Related issue(s)
Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.