Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reticle automatically issue query on move end #405

Open
prushforth opened this issue Apr 15, 2021 · 3 comments · May be fixed by #569
Open

Make reticle automatically issue query on move end #405

prushforth opened this issue Apr 15, 2021 · 3 comments · May be fixed by #569
Milestone

Comments

@prushforth
Copy link
Member

Currently queries only occur when the user hits enter or spacebar. In moving this feature towards a more accessible future, I believe it is appropriate to issue the query on move end when the reticle is deployed.

When we move to a square reticle with feature index, we'll perhaps be in a position to merge our treatment of tabbing through features already in the map layer and querying features from the server.

@ahmadayubi
Copy link
Member

After experimenting with this, I think automatically issuing queries should be added at the same time/after the popups are removed. Adding this while still having popups makes the experience, in my opinion, an annoying interaction.

@prushforth prushforth added this to the Fall term 2021 milestone Jul 30, 2021
@Malvoz
Copy link
Member

Malvoz commented Aug 5, 2021

Does automatically issuing queries on move end (have to) imply showing popups for the query results? I think that can be a bit disorienting to screen reader users because they'll have (potentially a lot of) content announced for something they did not ask for and aren't necessarily interested in. Also, popups recieve focus when displayed, which is generally useful, but in this case it means a keyboard user can not continuously pan without having to close popups between each increment.

feature index

For the feature index use case, I think we'll want to populate that UI with identifiers of available queries, such that users can choose if/when to interact with them (issue queries). Is there such a thing as a query "name"?
Or do we need something like <link rel="query" title="(name to be displayed in the feature index)">? If that makes sense so that we can have query identifiers without issuing queries to retrieve such information (saves data, mitigates fingerprinting)?

@Malvoz
Copy link
Member

Malvoz commented Aug 5, 2021

I do realize that there's currently nothing indicating to users that queries are available, which this would solve in some sense, even if it may be annoying to some users. IMO we're probably better off focusing our efforts on the Feature Index in this matter.

@Malvoz Malvoz mentioned this issue Aug 6, 2021
@ahmadayubi ahmadayubi linked a pull request Nov 12, 2021 that will close this issue
@prushforth prushforth modified the milestones: Fall term 2021, Summer 2022 May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants