Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto issue query on moveend, add test #569

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ahmadayubi
Copy link
Member

2021-11-12.11-47-40.mp4

I'm not sure if this is a valuable feature but was an issue in the repo, try it out to see if the functionality is useful, and provide feedback.

Closes #405

@Malvoz
Copy link
Member

Malvoz commented Nov 12, 2021

I don't think we should do this, see #405 (comment).

@ahmadayubi
Copy link
Member Author

I don't think we should do this, see #405 (comment).

I lean towards this as well, although once popup's are removed it may make more sense.

@Malvoz
Copy link
Member

Malvoz commented Nov 17, 2021

Then perhaps it's best to revisit this once #403 is resolved, and close this (and maybe the corresponding issue) for now? @prushforth @ahmadayubi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make reticle automatically issue query on move end
2 participants