Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor custom events dispatched by the Viewer #872

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

AliyanH
Copy link
Member

@AliyanH AliyanH commented Jul 11, 2023

Refactor leaflet specific events into map- namespace.

mapml-viewer/web-map

Changed:

  • locationfound -> map-locationfound
  • locationerror -> map-locationerror
  • preclick -> map-preclick
  • movestart -> map-movestart
  • move -> map-move
  • moveend -> map-moveend
  • zoomstart -> map-zoomstart
  • zoom -> map-zoom
  • zoomend -> map-zoomend

Unchanged:

  • load -> load
  • click -> click
  • dblclick -> dblclick
  • mousemove -> mousemove
  • mouseover -> mouseover
  • mouseout -> mouseout
  • mousedown -> mousedown
  • mouseup -> mouseup
  • contextmenu -> contextmenu

layer.js

  • loadstart (removed)
  • map-changestyle

closes #869

@AliyanH AliyanH linked an issue Jul 13, 2023 that may be closed by this pull request
@prushforth
Copy link
Member

Related PR for web-map-doc

… dispatch map-change event for map-extent + remove mapml-viewer/web-map preclick and layerchange event + modify templated tile tileloadstart->map-tileloadstart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants