Add missing XLATB group/import #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additional check are required to avoid generating 32-bit form of |
|
As far as I understand Intel’s docs addressSize defaults to 64 in long
mode and REX.W does not change that (cf section 3.6.1 Operand Size and
Address Size in 64-Bit Mode). The address-size prefix 67h does set
addressSize=32, but opcodes lists only REX.W. Am I missing something?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you thought about dropping x86_64.json (i.e. dump everything into a single file) and using import *? It took me a while to understand why newly added instructions (opcodes) did not generate classes until I closely looked at the codegen.