Delete unused global variables from mysqld.h #3244
Open
+7
−295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several variables declared in mysqld.h appear to be old system variables
that have been left over after deprecation. Delete them using IDE
refactoring to automatically search for other uses. Most cases had no
other uses in the code.
slave_allow_batching had a test that was effectively unused, as the
result was only
-ERROR HY000: Unknown system variable 'slave_allow_batching'
so that was deleted as well.
Build and test still works without issue as expected.
Examples of variables that were deleted and not cleaned up:
VERS_ALTER_HISTORY_KEEP
but did not delete it from the enum.key_memory_quick_index_merge_root
(and similar) tomysqld.cc
tomysqld.h
, but still was not used anywhere.key_thread_kill_server
along with others to header file, but still was used nowhere. I can't actually find where it was ever used except being defined in a header.Release Notes
None
How can this PR be tested?
Building the server and running the MTR test suite shows no failures.
Basing the PR against the correct MariaDB version
Note: As discussed with @LinuxJedi, this is targeting the earliest maintained branch to ease merging upwards, even though it is not necessarily a bugfix.
PR quality check