Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDEV-34057 Inconsistent FTS state in concurrent scenarios #3250

Open
wants to merge 1 commit into
base: 10.4
Choose a base branch
from
Open

MDEV-34057 Inconsistent FTS state in concurrent scenarios #3250

wants to merge 1 commit into from

Conversation

Thirunarayanan
Copy link
Member

@Thirunarayanan Thirunarayanan commented May 11, 2024 •
edited

  • The Jira issue number for this PR is: MDEV-34057

Description

  • InnoDB FTS can be in inconsistent state when sync operation terminates the server before committing the operation. This could lead to incorrect synced doc id and incorrect query results.
    Fix:
  • During sync commit operation, InnoDB should pass the sync transaction to update the max doc id
    in the config table.

How can this PR be tested?

./mtr innodb_fts.fts_sync_commit_resiliency

Basing the PR against the correct MariaDB version

  • This is a new feature and the PR is based against the latest MariaDB development branch.
  • This is a bug fix and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

@Thirunarayanan Thirunarayanan requested a review from dr-m May 11, 2024 16:33
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Thirunarayanan
MDEV-34057 Inconsistent FTS state in concurrent scenarios
1c20084 
Problem:
=======
- This commit is a merge of mysql commit 129ee47ef994652081a11ee9040c0488e5275b14.
InnoDB FTS can be in inconsistent state when sync operation
terminates the server before committing the operation. This
could lead to incorrect synced doc id and incorrect query results.

Solution:
========
- During sync commit operation, InnoDB should pass
the sync transaction to update the max doc id
in the config table.
dr-m
dr-m reviewed May 24, 2024
View reviewed changes
Copy link
Contributor

@dr-m dr-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be rebased on 10.5, because 10.4 is EOL. Is the patch for 10.6 identical?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-m dr-m dr-m left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@Thirunarayanan @CLAassistant @dr-m