Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to use node 16 #2233

Merged
merged 13 commits into from Mar 29, 2023
Merged

Upgrade to use node 16 #2233

merged 13 commits into from Mar 29, 2023

Conversation

yucheng11122017
Copy link
Contributor

@yucheng11122017 yucheng11122017 commented Mar 24, 2023

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Resolves #2197

Overview of changes:
Update CI scripts and documentation mention of the node.js version to 16

  • all user-facing functionalities are working
  • no issues with the development setup
  • whether related GitHub Actions need to be updated
    • PR opened for Github Actions opened updating version numbers
    • Deploying to github pages and surge upon push, build upon push, deploy review upon PR, reusable workflow is fine
  • any deprecated syntax to be refactored
    • None of the deprecated syntax is being used by markbind
  • docs are updated
  • Deployment to Netlify/other platforms is ok
    • PRs opened for netlify repos [PR1, PR2]to update version number
    • Currently unable to check deployment to Travis due to an error with account. This is currently unresolved by Travis
    • Deploying with Netlify, AppVeyor, Circle, Github Pages is ok

Anything you'd like to highlight/discuss:

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)
Upgrade nodejs to v16


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Breaking change descriptions:
Node.js version 14 is no longer supported by Markbind as it is due to reach it's end of life in 30 April 2023. The minimum required version of Node.js is now 16.
Users are to upgrade to at least version 16 of Node.js.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@yucheng11122017 yucheng11122017 marked this pull request as ready for review March 25, 2023 07:10
@yucheng11122017 yucheng11122017 changed the title [WIP] Upgrade to use node 16 Upgrade to use node 16 Mar 25, 2023
@tlylt tlylt requested a review from a team March 25, 2023 15:37
ong6
ong6 previously requested changes Mar 25, 2023
Copy link
Contributor

@ong6 ong6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few instances in docs/userGuide/deployingTheSite.md where the node version is set to 10. Perhaps we can update those too for consistancy. For example in the **Configuring your repository in Travis CI** section as well as the other sections below

@yucheng11122017
Copy link
Contributor Author

There are a few instances in docs/userGuide/deployingTheSite.md where the node version is set to 10. Perhaps we can update those too for consistancy. For example in the **Configuring your repository in Travis CI** section as well as the other sections below

Updated in cc7d97a! :)

@tlylt
Copy link
Contributor

tlylt commented Mar 28, 2023

Almost there, thanks @yucheng11122017, will aim to merge this one in soon. Btw can we include a page in our DG, perhaps something similar to "Migrating to TypeScript", to list out a checklist of things to do/check when migrating? I think your description is already quite comprehensive, can copy over and start from there.

@yucheng11122017
Copy link
Contributor Author

yucheng11122017 commented Mar 28, 2023

Almost there, thanks @yucheng11122017, will aim to merge this one in soon. Btw can we include a page in our DG, perhaps something similar to "Migrating to TypeScript", to list out a checklist of things to do/check when migrating? I think your description is already quite comprehensive, can copy over and start from there.

Ok! I will open a new issue for this

Edited: Opened #2246

@tlylt tlylt added the breakingChange 💥 Feature will behave significantly different, or is made obsolete label Mar 28, 2023
@tlylt tlylt added this to the v5.0.0 milestone Mar 28, 2023
@tlylt tlylt requested review from EltonGohJH and removed request for a team March 28, 2023 10:48
@tlylt tlylt merged commit c16cc59 into MarkBind:master Mar 29, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingChange 💥 Feature will behave significantly different, or is made obsolete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js v16 version update
3 participants