Lock dependencies by major version only #195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests have been failed. because of not properly resolved union after upgrading:
probably related to https://github.com/pydantic/pydantic-core/pull/ 867 (del ref)
more details
we have these types:
the logic that was before upgrading: try to match type one from
UnknownRecordTypePydantic
usingpy_type
field; if there is no match fallback toDotDictType
the logic after upgrading: it resolved all types as
DotDictType
BUT when i delete
DotDictType
from the Union it resolves fine (ofc doesn't fallback toDotDictType
but resolved theUnknownRecordTypePydantic
)!all the models in
UnknownRecordTypePydantic
Unioin use this config:so what should I do now to save
strict=True
, and exit from Union matching right after matching by discriminator (py_type
) field?upd.
strict=False
doesn't help