Fix Vue 2.7 compatibility

[Hawxy]

Removes the scope from the reactive object, fixing the RangeError: Maximum call stack size exceeded exception.

Note: I'm running the latest version of npm resulting in the package-lock being rebuilt, apologies for the diff size.

Fixes #82

[MartinMalinda]

Thanks! This looks promising. Good catch 👏

No need to fix tests here btw. Once we know it's working in 2.7, we can remove support for Vue < 2.7 remove the separate builds for Vue 2 and Vue 3 and even the separate test runs.

[Hawxy]

No worries. Travis appears unhappy with the new package-lock format & Vuepress with the composition-api removal so you may want to cherry pick this into whichever branch you want to test this in :)

[Hawxy]

@MartinMalinda I've pushed up a new version that tests against the v4 branch, is passing for myself locally. Just used vue-demi so I didn't need to change the test infrastructure.

[MartinMalinda]

@Hawxy that's probably the optimal path forward here, thanks a lot. I've tried vue-demi once before and I couldn't make somthing work with it, maybe the test suite, I'm not sure anymore.

I'll check more in detail soon, but it seems with this it will be possible to finally fully release v4.

[dschmidt]

Hey @MartinMalinda,

is there any chance to have at least another prerelease with this anytime soon?

[Hawxy]

This is also a blocker for my team so getting this in as soon as possible would be ideal :)

[MartinMalinda]

I'll be checking it this week, maybe tomorrow. Will let you know here once i have a prerelease, if it works for you, I'll do a new classic release finally.Sent from my iPhoneOn 7. 11. 2022, at 10:32, JT ***@***.***> wrote: This is also a blocker for my team so getting this in as soon as possible would be ideal :) —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[dschmidt]

I've played around with the PR and it works fine for me with Vue 2.7. Thanks a lot, @Hawxy!

Just a little heads up for anyone coming accross this: Although vue-demi (in general) can work with Vue < 2.7, this PR does not - so you need to switch to Vue 2.7 and the new vue-concurrency version at the same time.

[Hawxy]

it works fine for me with Vue 2.7.

Awesome 👍

Although vue-demi (in general) can work with Vue < 2.7, this PR does not

Because I didn't change any library internals to use vue-demi, I just used it so I could reuse the test infrastructure created for Vue 3. I'm aware it didn't used to work for this project, but someone might want to try again.

[dschmidt]

Yep, I understand - just wanted to point it out for anyone trying this or the new release :)

[MartinMalinda]

I've also tested this in a Vue 2.7 app and it works well. It's released in 4.0.0. Thanks @Hawxy and all others testing it!