Test enhancement #172
Open
Test enhancement #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter279k
force-pushed
the
test_enhancement
branch
from
e21e006
to
ed85067
Compare
goetas
requested changes
Nov 14, 2019
| @@ -645,8 +645,8 @@ public function testHandlingInvalidRawContent() | |||
|
|
|||
| $contents = $this->html5->saveHTML($dom); | |||
|
|
|||
| $this->assertTrue(false !== strpos($contents, '<script id="template" type="x-tmpl-mustache"> | |||
| $this->assertContains('<script id="template" type="x-tmpl-mustache"> | |||
There was a problem hiding this comment.
This should be assertStringContainsString (see https://phpunit.readthedocs.io/en/8.4/assertions.html#assertstringcontainsstring).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed log
setUpmethod isprotected, notpublic.assertTrueandassertFalseto assert expected value istrueandfalse.assertInternalTypeis assert expected value type isstring.assertContainsto assert the expected sub string contains on specific string result.