Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new error when int parsing fails #220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add new error when int parsing fails #220

wants to merge 1 commit into from

Conversation

crozzy
Copy link

@crozzy crozzy commented Oct 9, 2023

It's hard to reason with errors when strconv.ParseUint fails as the returned error is untyped. This change introduces a new error that is returned if the int parsing fails.

@crozzy
Add new error when int parsing fails
a24cef3 
It's hard to reason with errors when `strconv.ParseUint` fails as
the returned error is untyped. This change introduces a new error
that is returned if the int parsing fails.

Signed-off-by: crozzy <joseph.crosland@gmail.com>
@crozzy
Copy link
Author

crozzy commented Oct 9, 2023 •
edited

I suppose you could also wrap the err returned with %w ie. fmt.Errorf("Error parsing version segment: %w", err), to allow to caller to discern why things failed. It's a weird one because it could also be validated in the regex I suppose but judging by the spec it's not technically an invalid semver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@crozzy