Skip to content

Commit

Permalink
Merge pull request #172 from thedevsaddam/v1
Browse files Browse the repository at this point in the history
Add go-module support and fix lint issues
  • Loading branch information
lann committed Dec 19, 2018
2 parents a8c1880 + ca085d9 commit b56af23
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 8 deletions.
18 changes: 10 additions & 8 deletions expr.go
Expand Up @@ -78,7 +78,7 @@ func (e aliasExpr) ToSql() (sql string, args []interface{}, err error) {
// .Where(Eq{"id": 1})
type Eq map[string]interface{}

func (eq Eq) toSql(useNotOpr bool) (sql string, args []interface{}, err error) {
func (eq Eq) toSQL(useNotOpr bool) (sql string, args []interface{}, err error) {
if len(eq) == 0 {
// Empty Sql{} evaluates to true.
sql = sqlTrue
Expand All @@ -102,7 +102,7 @@ func (eq Eq) toSql(useNotOpr bool) (sql string, args []interface{}, err error) {

sortedKeys := getSortedKeys(eq)
for _, key := range sortedKeys {
expr := ""
var expr string
val := eq[key]

switch v := val.(type) {
Expand Down Expand Up @@ -149,7 +149,7 @@ func (eq Eq) toSql(useNotOpr bool) (sql string, args []interface{}, err error) {
}

func (eq Eq) ToSql() (sql string, args []interface{}, err error) {
return eq.toSql(false)
return eq.toSQL(false)
}

// NotEq is syntactic sugar for use with Where/Having/Set methods.
Expand All @@ -158,7 +158,7 @@ func (eq Eq) ToSql() (sql string, args []interface{}, err error) {
type NotEq Eq

func (neq NotEq) ToSql() (sql string, args []interface{}, err error) {
return Eq(neq).toSql(true)
return Eq(neq).toSQL(true)
}

// Like is syntactic sugar for use with LIKE conditions.
Expand Down Expand Up @@ -238,7 +238,7 @@ func (lt Lt) toSql(opposite, orEq bool) (sql string, args []interface{}, err err

sortedKeys := getSortedKeys(lt)
for _, key := range sortedKeys {
expr := ""
var expr string
val := lt[key]

switch v := val.(type) {
Expand Down Expand Up @@ -304,12 +304,12 @@ func (c conj) join(sep, defaultExpr string) (sql string, args []interface{}, err
}
var sqlParts []string
for _, sqlizer := range c {
partSql, partArgs, err := sqlizer.ToSql()
partSQL, partArgs, err := sqlizer.ToSql()
if err != nil {
return "", nil, err
}
if partSql != "" {
sqlParts = append(sqlParts, partSql)
if partSQL != "" {
sqlParts = append(sqlParts, partSQL)
args = append(args, partArgs...)
}
}
Expand All @@ -319,12 +319,14 @@ func (c conj) join(sep, defaultExpr string) (sql string, args []interface{}, err
return
}

// And conjunction Sqlizers
type And conj

func (a And) ToSql() (string, []interface{}, error) {
return conj(a).join(" AND ", sqlTrue)
}

// Or conjunction Sqlizers
type Or conj

func (o Or) ToSql() (string, []interface{}, error) {
Expand Down
9 changes: 9 additions & 0 deletions go.mod
@@ -0,0 +1,9 @@
module github.com/Masterminds/squirrel

require (
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/lann/builder v0.0.0-20180802200727-47ae307949d0
github.com/lann/ps v0.0.0-20150810152359-62de8c46ede0 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/stretchr/testify v1.2.2
)
10 changes: 10 additions & 0 deletions go.sum
@@ -0,0 +1,10 @@
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/lann/builder v0.0.0-20180802200727-47ae307949d0 h1:SOEGU9fKiNWd/HOJuq6+3iTQz8KNCLtVX6idSoTLdUw=
github.com/lann/builder v0.0.0-20180802200727-47ae307949d0/go.mod h1:dXGbAdH5GtBTC4WfIxhKZfyBF/HBFgRZSWwZ9g/He9o=
github.com/lann/ps v0.0.0-20150810152359-62de8c46ede0 h1:P6pPBnrTSX3DEVR4fDembhRWSsG5rVo6hYhAB/ADZrk=
github.com/lann/ps v0.0.0-20150810152359-62de8c46ede0/go.mod h1:vmVJ0l/dxyfGW6FmdpVm2joNMFikkuWg0EoCKLGUMNw=
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/stretchr/testify v1.2.2 h1:bSDNvY7ZPG5RlJ8otE/7V6gMiyenm9RtJ7IUVIAoJ1w=
github.com/stretchr/testify v1.2.2/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs=

0 comments on commit b56af23

Please sign in to comment.