Add missing MustSql methods #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems CI errors are unrelated to this PR. |
|
I wonder if it would make sense to have a single function |
|
Yes, that probably makes sense considering the number of possible SQL operations. However, my current implementation follows the same chaining logic as other methods do, which might feel more intuitive. |
|
Besides, there's already a |
|
@lann do you have more thoughts on this? |
|
Send reasonable and consistent |
This was referenced Oct 13, 2021
Merged
1 task
kodiakhq bot
pushed a commit
to cloudquery/cq-provider-sdk
that referenced
this pull request
Jun 20, 2022
) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/Masterminds/squirrel](https://togithub.com/Masterminds/squirrel) | require | patch | `v1.5.0` -> `v1.5.3` | --- ### Release Notes <details> <summary>Masterminds/squirrel</summary> ### [`v1.5.3`](https://togithub.com/Masterminds/squirrel/compare/v1.5.2...v1.5.3) [Compare Source](https://togithub.com/Masterminds/squirrel/compare/v1.5.2...v1.5.3) ### [`v1.5.2`](https://togithub.com/Masterminds/squirrel/releases/tag/v1.5.2) [Compare Source](https://togithub.com/Masterminds/squirrel/compare/v1.5.1...v1.5.2) #### What's Changed - [#​301](https://togithub.com/Masterminds/squirrel/issues/301) Conjunction produces wrong dollar parameter placeholders by [@​strider2038](https://togithub.com/strider2038) in [Masterminds/squirrel#302 ### [`v1.5.1`](https://togithub.com/Masterminds/squirrel/releases/tag/v1.5.1) [Compare Source](https://togithub.com/Masterminds/squirrel/compare/v1.5.0...v1.5.1) #### What's Changed - doc: fix deprecated usage of NewStmtCache by [@​elvizlai](https://togithub.com/elvizlai) in [Masterminds/squirrel#274 - Add missing MustSql methods by [@​swithek](https://togithub.com/swithek) in [Masterminds/squirrel#288 - Fix Select subquery with DollarPlaceholder by [@​lann](https://togithub.com/lann) in [Masterminds/squirrel#298 #### New Contributors - [@​swithek](https://togithub.com/swithek) made their first contribution in [Masterminds/squirrel#288 **Full Changelog**: Masterminds/squirrel@v1.5.0...v1.5.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MustSql()method onSelectBuildertends to be quite useful when working with less dynamic queries, however, at the moment, it's not possible to have the same flow with queries made withCaseBuilder,DeleteBuilder,InsertBuilderandUpdateBuilder. This PR addsMustSql()method to all of them.Related PR: #156