Skip to content

Commit

Permalink
Fix pnpm install failing because of our publish script
Browse files Browse the repository at this point in the history
Version v7.20.0 of pnpm introduced a change that makes it run our
publish script on install, breaking CI pipelines and local envs
alike.

See: pnpm/pnpm#5837
See: pnpm/pnpm#5826
See: https://github.com/pnpm/pnpm/releases/tag/v7.20.0

On environments where the pnpm store is cached, doing a second pnpm
install solves the issue. These doesn't work in envs like Docker tho.

Could be fixed by adding a `main` field to the top-level package.json
as version v7.22.0 added a check for that.

See: https://github.com/pnpm/pnpm/releases/tag/v7.22.0
See: pnpm/pnpm#5868

But since we are not really publishing these packages we can just
remove the script.

[f:2h]
  • Loading branch information
stefanmaric committed Jan 10, 2023
1 parent e9d23ea commit 6cec6d2
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Expand Up @@ -2,6 +2,8 @@

## Unreleased

- Fix pnpm install failing because of our publish script

## 2.1.0 - 2021-12-22

- Update docs about ditching prop-types when working with TS
Expand Down
1 change: 0 additions & 1 deletion package.json
Expand Up @@ -15,7 +15,6 @@
"license": "MIT",
"prettier": "./prettier",
"scripts": {
"publish": "pnpm recursive --filter '@masterworks/*' exec --workspace-concurrency 1 -- pnpm publish --access public",
"version": "pnpm recursive exec -- npm version --no-git-tag-version"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 6cec6d2

Please sign in to comment.