storage: wire up new reclock implementation #27058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrosagg
force-pushed
the
wire-up-new-reclock
branch
from
482e57a
to
5f2462c
Compare
guswynn
reviewed
May 13, 2024
| @@ -35,7 +35,6 @@ pub(crate) struct GeneralSourceMetricDefs { | |||
| // Source metrics | |||
| pub(crate) capability: UIntGaugeVec, | |||
| pub(crate) resume_upper: IntGaugeVec, | |||
| pub(crate) inmemory_remap_bindings: UIntGaugeVec, | |||
There was a problem hiding this comment.
we still have some metrics we can keep track of right?
deferred_source_bindings and the remap trace lenths seem nice?
| }; | ||
| ((output, result), from_time, diff) | ||
| }) | ||
| .capture_into(PusherCapture(reclock_pusher)); |
Comment on lines
175
to
191
| let resume_upper = if PartialOrder::less_equal(upper, &as_of) { | ||
| Antichain::from_elem(Timestamp::minimum()) | ||
| } else { | ||
| let idx = remap_updates.partition_point(|(_, t, _)| !upper.less_than(t)); | ||
| source_upper.clear(); | ||
| source_upper.update_iter( | ||
| remap_updates[0..idx] | ||
| .iter() | ||
| .map(|(from_time, _, diff)| (from_time.clone(), *diff)), | ||
| ); | ||
| source_upper.frontier().to_owned() | ||
| }; | ||
| source_resume_uppers.insert(*id, resume_upper); |
There was a problem hiding this comment.
I know its basic now, but can this be abstracted into a function in the mz_storage::reclock module?
petrosagg
force-pushed
the
wire-up-new-reclock
branch
from
5f2462c
to
be82541
Compare
5 tasks
petrosagg
force-pushed
the
wire-up-new-reclock
branch
from
be82541
to
15ac2c7
Compare
rjobanp
approved these changes
Jun 3, 2024
Comment on lines
+177
to
+191
| } else { | ||
| let idx = remap_updates.partition_point(|(_, t, _)| !upper.less_equal(t)); | ||
| source_upper.clear(); | ||
| source_upper.update_iter( | ||
| remap_updates[0..idx] | ||
| .iter() | ||
| .map(|(from_time, _, diff)| (from_time.clone(), *diff)), | ||
| ); | ||
| source_upper.frontier().to_owned() | ||
| }; | ||
| source_resume_uppers.insert(*id, resume_upper); |
There was a problem hiding this comment.
we've lost the tests and comments associated with this logic due to removing the source_upper_at_frontier method -- can we add back some sort of explanation comment for this? Similar to the previous one?
/// The conversion has the property that all messages that would be reclocked to times beyond
/// the provided `IntoTime` frontier will be beyond the returned `FromTime` frontier. This can
/// be used to compute a safe starting point to resume producing an `IntoTime` collection at a
/// particular frontier.
15ac2c7
to
1e8e3b2
Compare
petrosagg
force-pushed
the
wire-up-new-reclock
branch
from
1e8e3b2
to
10abb1c
Compare
This was referenced Jun 4, 2024
5 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With the new reclock implementation now merged, this PR integrates it into the ingestion pipeline and deletes the old one
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.