Support container builders for flat_map variants #27107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for specifying the container builder to the various variants of `flat_map` and adjusts the call sites. Most use the default capacity-based builder, but some switch to the consolidating variant. I selected places that apply scalar expressions to rows for the consolidating variant, which have the chance to change rows sufficiently that it enables further consolidation. Signed-off-by: Moritz Hoffmann <mh@materialize.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>
antiguru
force-pushed
the
flat_map_container_builder
branch
from
b915663
to
f38875a
Compare
5 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for specifying the container builder to the various variants of
flat_mapand adjusts the call sites. Most use the default capacity-based builder, but some switch to the consolidating variant. I selected places that apply scalar expressions to rows for the consolidating variant, which have the chance to change rows sufficiently that it enables further consolidation.Best viewed with whitespace changes hidden!
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.