compute: EagerUnaryFunc::could_error()default implementation
#27113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds DupliicatePrivateLinkAvailabilityZone errors
- validates no dupilicates in ddl
- adds test for error condtion
Co-authored-by: Nikhil Benesch <nikhil.benesch@gmail.com>
…late a real 'size diff' for estimating working-set size
… for functions that may or may not fail
…ecurity-context drop capabilities, don't allow running as root
release: bump to version v0.100.0-dev
This reveals a bug in column name inference for fast path plans.
Teach `ConnCatalog::column_names_for_id` to correctly infer column vectors for `GlobalId` values that indentify an `Index`. Fix a bug in the `FastPathPlan::PeekExisting` part of the `DisplayText` for `FastPathPlan` by resolving column names of the `idx_id`.
…tribute attribute: deprecate in favor of `analysis` framework
This change adds support for specifying the container builder to the various variants of `flat_map` and adjusts the call sites. Most use the default capacity-based builder, but some switch to the consolidating variant. I selected places that apply scalar expressions to rows for the consolidating variant, which have the chance to change rows sufficiently that it enables further consolidation. Best viewed with whitespace changes hidden! ### Checklist - [ ] This PR has adequate test coverage / QA involvement has been duly considered. ([trigger-ci for additional test/nightly runs](https://trigger-ci.dev.materialize.com/)) - [ ] This PR has an associated up-to-date [design doc](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/README.md), is a design doc ([template](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/00000000_template.md)), or is sufficiently small to not require a design. <!-- Reference the design in the description. --> - [ ] If this PR evolves [an existing `$T ⇔ Proto$T` mapping](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/command-and-response-binary-encoding.md) (possibly in a backwards-incompatible way), then it is tagged with a `T-proto` label. - [ ] If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label ([example](MaterializeInc/cloud#5021)). <!-- Ask in #team-cloud on Slack if you need help preparing the cloud PR. --> - [ ] This PR includes the following [user-facing behavior changes](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/guide-changes.md#what-changes-require-a-release-note): - <!-- Add release notes here or explicitly state that there are no user-facing behavior changes. --> --------- Signed-off-by: Moritz Hoffmann <mh@materialize.com>
…unknown-panic compute: fix "frontier updates for unknown collection" error
Signed-off-by: Moritz Hoffmann <mh@materialize.com>
…t/pip/ci/builder/pymysql-1.1.1 build(deps): bump pymysql from 1.0.2 to 1.1.1 in /ci/builder
Fix merge skew, add container builder arguments to flat_map
… for functions that may or may not fail
|
|
|
Retrying with a proper diff. No idea why that rebase did that. 🤔 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands,
LazyUnaryFunchas a blanket implementation on::could_error()that looks atSelf::Output. But some operations---text_to_varchar---may or may not fail depending on parameters.This PR gives a little more flexibility.
Motivation
More fine-grained metadata on unary operations.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.