pgcompat: add some missing columns for Metaplane #27155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pH14
changed the title
pg_user table + some missing columns
For compatibility with Metaplane.
For Metaplane compatibility.
benesch
force-pushed
the
pgcompat-metaplane
branch
from
d8efb30
to
6fdffbc
Compare
benesch
changed the title
pg_user table + some missing columns
|
I got excited about this. The |
benesch
approved these changes
May 18, 2024
benesch
added a commit
to benesch/materialize
that referenced
this pull request
May 18, 2024
For Metaplane compatibility. To bring our `pg_user`, `pg_roles`, and `pg_authid` views in line with PostgreSQL, this commit also refactors how `rolcanlogin` is derived. We now do something a little gross but that will work well in practice to derive `rolcanlogin` from whether a role name looks like an email address, instead of hardcoding `NULL`. This makes the distinction between `pg_user` and `pg_roles` more useful: the former contains only the roles for which `rolcanlogin` is true, while the latter contains all roles. Split out from MaterializeInc#27155. Co-authored-by: Nikhil Benesch <nikhil.benesch@gmail.com>
5 tasks
Done in #27161. |
benesch
added a commit
to benesch/materialize
that referenced
this pull request
May 18, 2024
For Metaplane compatibility. To bring our `pg_user`, `pg_roles`, and `pg_authid` views in line with PostgreSQL, this commit also refactors how `rolcanlogin` is derived. We now do something a little gross but that will work well in practice to derive `rolcanlogin` from whether a role name looks like an email address, instead of hardcoding `NULL`. This makes the distinction between `pg_user` and `pg_roles` more useful: the former contains only the roles for which `rolcanlogin` is true, while the latter contains all roles. Split out from MaterializeInc#27155. Co-authored-by: Nikhil Benesch <nikhil.benesch@gmail.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improvements to our Postgres compatibility story. More context: https://materializeinc.slack.com/archives/C073KLQ0QHM/p1715968613948499
Adds inMoved to sql: addpg_catalog.pg_userpg_catalog.pg_userview #27161.reltuplescolumn topg_catalog.pg_classcolumn_defaultcolumn toinformation_schema.columnsTips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.