Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: support cvs format options in copy-to-s3 #27160

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

maddyblue
Copy link
Contributor

These were being silently ignored.

Motivation

  • This PR fixes a previously unreported bug.

Checklist

@maddyblue maddyblue requested a review from rjobanp May 18, 2024 06:29
@maddyblue maddyblue requested a review from a team as a code owner May 18, 2024 06:29
@maddyblue maddyblue requested a review from jkosh44 May 18, 2024 06:29
@maddyblue
Copy link
Contributor Author

@rjobanp Saw this when looking at some code. I didn't see a test that asserted file contents of the uploaded s3 files, so that should be added here before merging. Are you or someone from testing able to take that over?

Copy link
Contributor

@rjobanp rjobanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for implementing this!

@rjobanp
Copy link
Contributor

rjobanp commented May 31, 2024

I didn't see a test that asserted file contents of the uploaded s3 files

Sorry just saw this comment! We do assert the contents of files in this test https://github.com/MaterializeInc/materialize/blob/main/test/testdrive/copy-to-s3-minio.td#L145-L158

I'll update this PR to validate that these format options also affect the CSV output format there

@rjobanp rjobanp merged commit b06878e into MaterializeInc:main Jun 4, 2024
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants