Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SchedulePlanChangeRequest, make CustomerCostParamsFilter pub #39

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

aarashy
Copy link
Contributor

@aarashy aarashy commented Mar 16, 2024

Adds the API for updating a customer subscription in place.

Also makes CustomerCostParamsFilter pub

@benesch benesch requested a review from arusahni March 16, 2024 18:16
@arusahni
Copy link
Collaborator

Thanks for filing this PR @aarashy! Could you elaborate upon the need for changing the visibility of CustomerCostParamsFilter? This is intentionally not exposed outside of the crate as we use the builder pattern for parameter collections. So, instead of doing something like:

get_customer_costs(&customer_id, &CustomerCostParams { filter: CustomerCostParamsFilter { view_mode: CostViewMode::Periodic, ..Default::default() } })

clients can instead invoke this as

get_customer_costs(&customer_id, &CustomerCostParams::default().view_mode(CostViewMode::Periodic))

@aarashy aarashy force-pushed the main branch 13 times, most recently from 51bcf44 to 5ad9f4c Compare March 25, 2024 08:52
@aarashy aarashy force-pushed the main branch 5 times, most recently from 306fd00 to e73a989 Compare March 27, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants