Don't generate packing reports unnecessarily when displaying the repo…

…rt form
Matt-Yorkley · Mar 23, 2024 · 5800886 · 5800886
1 parent 26f3b56
commit 5800886
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 11 deletions.
diff --git a/lib/reporting/reports/packing/customer.rb b/lib/reporting/reports/packing/customer.rb
@@ -5,10 +5,10 @@ module Reports
     module Packing
       class Customer < Base
         def columns
-          # Reorder default columns
-          super.slice(:hub, :customer_code, :first_name, :last_name, :phone,
-                      :supplier, :product, :variant, :weight, :height, :width, :depth, :quantity,
-                      :price, :temp_controlled)
+          Struct.new(:keys).new(
+            [:hub, :customer_code, :first_name, :last_name, :phone,:supplier, :product,
+             :variant, :weight, :height, :width, :depth, :quantity, :price, :temp_controlled]
+          )
         end
 
         def rules

diff --git a/lib/reporting/reports/packing/product.rb b/lib/reporting/reports/packing/product.rb
@@ -5,10 +5,10 @@ module Reports
     module Packing
       class Product < Base
         def columns
-          # Reorder default columns
-          super.slice(:hub, :supplier, :product, :variant,
-                      :customer_code, :first_name, :last_name, :phone,
-                      :quantity, :price, :temp_controlled)
+          Struct.new(:keys).new(
+            [:hub, :supplier, :product, :variant, :customer_code, :first_name,
+             :last_name, :phone, :quantity, :price, :temp_controlled]
+          )
         end
 
         def rules

diff --git a/lib/reporting/reports/packing/supplier.rb b/lib/reporting/reports/packing/supplier.rb
@@ -5,9 +5,10 @@ module Reports
     module Packing
       class Supplier < Base
         def columns
-          # Reorder default columns
-          super.slice(:hub, :supplier, :customer_code, :first_name, :last_name, :phone,
-                      :product, :variant, :quantity, :price, :temp_controlled)
+          Struct.new(:keys).new(
+            [:hub, :supplier, :customer_code, :first_name, :last_name, :phone,
+             :product, :variant, :quantity, :price, :temp_controlled]
+          )
         end
 
         def rules