Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[keyring-controller] Add :withKeyring action #4226

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[keyring-controller] Add :withKeyring action #4226

wants to merge 2 commits into from

Conversation

mikesposito
Copy link
Member

Explanation

This PR adds the KeyringController:withKeyring action to KeyringController.

References

Changelog

@metamask/keyring-controller

  • ADDED: Added KeyringController:withKeyring action
  • DEPRECATED: Deprecated KeyringController:getKeyringForAccount action
    • Use KeyringController:withKeyring or KeyringController:getState instead
  • DEPRECATED: Deprecated KeyringController:getKeyringsByType action
    • Use KeyringController:withKeyring or KeyringController:getState instead

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@mikesposito mikesposito mentioned this pull request Apr 29, 2024
Merged
3 tasks
@mikesposito mikesposito force-pushed the feat/with-keyring branch 3 times, most recently from 404cf84 to eeff1a2 Compare April 30, 2024 09:50
Base automatically changed from feat/with-keyring to main April 30, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mikesposito