feat: added pairIdentifiers service #4269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/profile-sync-controller/src/sdk/authentication-jwt-bearer/types.ts
Show resolved
Hide resolved
dovydas55
commented
May 14, 2024
| @@ -50,6 +58,36 @@ export class JwtBearerAuth implements SIWEInterface, SRPInterface { | |||
| return await this.#sdk.signMessage(message); | |||
| } | |||
|
|
|||
| async pairIdentifiers(pairing: Pair[]): Promise<void> { | |||
There was a problem hiding this comment.
Hmmm...
I'm hesitant if implementations should be done in this combined class vs in the individual implementations.
Context:
- Combined Class: 1 class; but poor type interface
- Individual Class: the developer can choose a specific implementation & has great type interface.
There was a problem hiding this comment.
Yes lets move the implementation to the individual classes, that way the better typed implementations can also utilise this method.
Either do this now, or in a separate implementation.
There was a problem hiding this comment.
Only annoying thing is that the implementation is identical on both implementations, so a bit redundant. (Sadly JS does not support the trait system lol).
Even though there would be duplication, I think it is nicer to have that abstraction.
Prithpal-Sooriya
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Adding pairing profile functionality to the profile sync SDK.
@metamask/profile-sync-controller/sdkChecklist