Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tokens-controller] Expose getState action and stateChange event #4278

Closed
wants to merge 4 commits into from
Closed

[tokens-controller] Expose getState action and stateChange event #4278

wants to merge 4 commits into from

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented May 14, 2024 •
edited

Explanation

References

Changelog

@metamask/package-a

  • : Your change here
  • : Your change here

@metamask/package-b

  • : Your change here
  • : Your change here

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@MajorLift MajorLift requested a review from a team as a code owner May 14, 2024 10:49
@MajorLift MajorLift self-assigned this May 14, 2024
mcmire
mcmire reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some tests for the two action handlers as well as the stateChange being published whenever there is a state update?

mikesposito
mikesposito approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I do agree that it would be nice to have this covered by tests

@MajorLift
Copy link
Contributor Author

Superseded by #4304

@MajorLift MajorLift closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire left review comments

@mikesposito mikesposito mikesposito approved these changes

Assignees

@MajorLift MajorLift

Labels
team-wallet-framework
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tokens-controller] Expose getState action and stateChange event
3 participants
@MajorLift @mcmire @mikesposito