[keyring-controller]: Add changePassword method
#4279
Conversation
mikesposito
force-pushed
the
feat/set-password
branch
from
a2d3dd9
to
0be3ac6
Compare
mikesposito
changed the title
setPassword methodsetPassword method
| // to force the controller to re-encrypt the vault using | ||
| // the new password. | ||
| if (this.#cacheEncryptionKey) { | ||
| this.update((state) => { |
There was a problem hiding this comment.
#persistOrRollback will not be able to roll this back, so in case of errors during vault update clients will have to derive the key again
There was a problem hiding this comment.
From what I can tell, the impact of discarding these would be that the password would be used for vault persistence instead of the key, but that's all. And even then, that's only the case of cacheEncryptionKey is enabled, otherwise the password is always used. Does that sound right? This doesn't seem harmful if that's the case.
There was a problem hiding this comment.
yes I agree, in case of error consumers will just have to unlock with password again. Mine was a consideration more than a concern - I'm not 100% sure of MV3 implications but I'm guessing that the behaviour is the same, user having to enter the password again
mikesposito
changed the title
setPassword methodchangePassword method
Explanation
This PR adds
changePasswordas a new method for KeyringController, useful for changing the current password.This addition aims to make it easier for clients to update the password, which is something that they currently need to implement themself
References
Changelog
@metamask/keyring-controllerchangePasswordmethodChecklist