Disable @typescript-eslint/no-unnecessary-type-assertion #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**This change is breaking.** We could bump this monorepo to Node 18, but since these packages are heavily depended upon, we don't need to do that yet until we've confirmed all other projects are using 18. Using the LTS version of Node puts us on a more modern version for development (and also happens to fix the `.nvmrc` file so `asdf` can read it).
This rule, as we've discovered after running it against the `core` monorepo, seems to produce false negatives. If you look at the issues list for the `typescript-eslint` repo and filter by this rule, you'll notice that [other people have reported this as well][1]. As a result, it's not worth enabling right now. [1]: https://github.com/typescript-eslint/typescript-eslint/issues?q=is%3Aissue+is%3Aopen+no-unnecessary-type-assertion+sort%3Aupdated-desc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule, as we've discovered after running it against the
coremonorepo, seems to produce false negatives. If you look at the issues list for thetypescript-eslintrepo and filter by this rule, you'll notice that other people have reported this as well. As a result, it's not worth enabling right now.