Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes our local unit test package scripts. When the state migration unit tests were migrated to Jest in #12106, it left the
test:unit
script in a broken state, because it didn't tellmocha
to ignore the state migration tests.Arguably, that script was already broken, since the most reasonably expectation from its name is that it runs all unit tests. The PR makes it so that it does just that, by means of
concurrently
.Unfortunately,
concurrently
only outputs errors from child processes once (at the time when they exit, open-cli-tools/concurrently#134). This means that we have to search/navigate the output for this combined script to identify the failure. That said, it's better than the status quo.