Updating stylelint from v13 to v14 and fixing linting issues WIP #14743
+1,538
−1,884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
georgewrmarshall
force-pushed
the
update/stylelint
branch
from
2372b3d
to
da36638
Compare
| @@ -100,12 +101,15 @@ module.exports = { | |||
| 'selector-attribute-brackets-space-inside': 'never', | |||
| 'selector-attribute-operator-space-after': 'never', | |||
| 'selector-attribute-operator-space-before': 'never', | |||
| 'selector-class-pattern': | |||
| '^(?:(?:o|c|u|t|s|is|has|_|js|qa)-)?[a-zA-Z0-9]+(?:-[a-zA-Z0-9]+)*(?:__[a-zA-Z0-9]+(?:-[a-zA-Z0-9]+)*)?(?:--[a-zA-Z0-9]+(?:-[a-zA-Z0-9]+)*)?(?:\\[.+\\])?$', // BEM naming convention | |||
There was a problem hiding this comment.
This is an attempt at checking for the BEM naming convention. It's works quite well but we do have css like:
.component-name {
_sub-component {
&.btn {
width: 100%;
}
}
}which it flags
|
Closing in favour of #13896 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Currently we are using
stylelint13.6. This PR updates stylelint to14.6.3by following the Migrating to 14.0.0 guide. It also updates a fair amount of css linting issues that are flagged by v14Some issues with this PR that should be resolved before it can be reviewed
gulp-stylelintwhich we are using(not sure for what) does not supportv14this PR is currently using a workaround Upgrade to newer version of stylelint olegskl/gulp-stylelint#132 (comment) is this a security issue and if so how do we make so it's not?vscode stylelint plugin also mentions that styleint 13 is no longer supported.
Manual Testing Steps
Run
yarn lint: stylesPre-Merge Checklist