Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch tar-stream to fix a race condition when installing snaps #22602

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Jan 18, 2024

Description

tar-stream has a bug where it randomly fails to decode tar headers due to mixing of Uint8Array and polyfilled Buffer. I have upstreamed a fix for this, but while we wait for it to be released, this patch should fix the issue!

Context on the bug: mafintosh/tar-stream#164

@FrederikBolding FrederikBolding added DO-NOT-MERGE Pull requests that should not be merged team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead labels Jan 18, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jan 18, 2024
@FrederikBolding FrederikBolding removed the DO-NOT-MERGE Pull requests that should not be merged label Jan 19, 2024
@FrederikBolding FrederikBolding marked this pull request as ready for review January 19, 2024 08:36
@FrederikBolding FrederikBolding requested a review from a team as a code owner January 19, 2024 08:36
@FrederikBolding FrederikBolding merged commit 9740c82 into develop Jan 19, 2024
70 of 76 checks passed
@FrederikBolding FrederikBolding deleted the fb/snaps-tar-stream-patch branch January 19, 2024 09:29
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
@metamaskbot metamaskbot added the release-11.10.0 Issue or pull request that will be included in release 11.10.0 label Jan 19, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [354a16c]
Page Load Metrics (1357 ± 143 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint932751655727
domContentLoaded9200556632
load84419251357299143
domInteractive9200556632
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 2 Bytes (0.00%)

@ziedbrini ziedbrini added team-snaps-platform Snaps Platform team and removed team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead labels Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.10.0 Issue or pull request that will be included in release 11.10.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants