chore(deps): Bump notification-controller to ^5.0.1 #24430
+174
−446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
mikesposito
added
team-wallet-framework
dependencies
|
@metamaskbot update-policies |
|
Policies updated |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/notification-controller@3.1.3, npm/aproba@1.2.0, npm/are-we-there-yet@1.1.4, npm/console-control-strings@1.1.0, npm/detect-libc@1.0.3, npm/gauge@2.7.4, npm/has-unicode@2.0.1, npm/ignore-walk@3.0.1, npm/needle@2.4.0, npm/node-pre-gyp@0.12.0, npm/npm-bundled@1.0.6, npm/npm-packlist@1.4.1, npm/npmlog@4.1.2, npm/os-tmpdir@1.0.2, npm/osenv@0.1.5, npm/wide-align@1.1.5 |
legobeat
previously approved these changes
May 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24430 +/- ##
===========================================
- Coverage 67.37% 65.77% -1.60%
===========================================
Files 1278 1366 +88
Lines 49881 54254 +4373
Branches 12944 14101 +1157
===========================================
+ Hits 33605 35685 +2080
- Misses 16276 18569 +2293 ☔ View full report in Codecov by Sentry. |
Builds ready [2de8b77]
Page Load Metrics (540 ± 459 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [feb1f32]
Page Load Metrics (962 ± 588 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [9c49dd4]
Page Load Metrics (1046 ± 582 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
|
@metamaskbot update-policies |
|
Policies updated |
Builds ready [6843c3f]
Page Load Metrics (974 ± 585 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The primary purpose for upgrading this package is to ensure that we are using a version which relies on
@metamask/base-controllerv5, which protects state from being mutated accidentally and includes more type safety for messengers, among other improvements.See changelog:
https://github.com/MetaMask/core/blob/%40metamask/notification-controller%405.0.1/packages/notification-controller/CHANGELOG.md
Related issues
Progresses #24140
Manual testing steps
There should be no functional changes in this PR
Screenshots/Recordings
None
Pre-merge author checklist
Pre-merge reviewer checklist