New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Bump rate-limit-controller to ^5.0.1 #24433
Conversation
@metamaskbot update-policies |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/rate-limit-controller@3.0.3 |
Policies updated |
Builds ready [6d6e814]
Page Load Metrics (887 ± 604 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24433 +/- ##
===========================================
+ Coverage 67.37% 67.48% +0.11%
===========================================
Files 1278 1288 +10
Lines 49881 50153 +272
Branches 12944 13023 +79
===========================================
+ Hits 33605 33842 +237
- Misses 16276 16311 +35 ☔ View full report in Codecov by Sentry. |
Builds ready [4b4272c]
Page Load Metrics (965 ± 590 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Builds ready [7521684]
Page Load Metrics (873 ± 592 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
The primary purpose for upgrading this package is to ensure that we are using a version which relies on
@metamask/base-controller
>v4, which protects state from being mutated accidentally and includes more type safety for messengers, among other improvements.See changelog:
https://github.com/MetaMask/core/blob/%40metamask/rate-limit-controller%405.0.1/packages/rate-limit-controller/CHANGELOG.md
Related issues
Progresses #24140
Manual testing steps
There should be no functional changes in this PR
Screenshots/Recordings
None
Pre-merge author checklist
Pre-merge reviewer checklist