Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump rate-limit-controller to ^5.0.1 #24433

Merged
merged 5 commits into from May 14, 2024

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented May 8, 2024

Description

The primary purpose for upgrading this package is to ensure that we are using a version which relies on @metamask/base-controller >v4, which protects state from being mutated accidentally and includes more type safety for messengers, among other improvements.

See changelog:
https://github.com/MetaMask/core/blob/%40metamask/rate-limit-controller%405.0.1/packages/rate-limit-controller/CHANGELOG.md

Open in GitHub Codespaces

Related issues

Progresses #24140

Manual testing steps

There should be no functional changes in this PR

Screenshots/Recordings

None

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mikesposito
Copy link
Member Author

@metamaskbot update-policies

Copy link

socket-security bot commented May 8, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/rate-limit-controller@5.0.1 None 0 94.4 kB metamaskbot

🚮 Removed packages: npm/@metamask/rate-limit-controller@3.0.3

View full report↗︎

@metamaskbot
Copy link
Collaborator

Policies updated

@mikesposito mikesposito marked this pull request as ready for review May 8, 2024 13:32
@mikesposito mikesposito requested review from a team as code owners May 8, 2024 13:32
@metamaskbot
Copy link
Collaborator

Builds ready [6d6e814]
Page Load Metrics (887 ± 604 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint67170932713
domContentLoaded105517136
load5630608871259604
domInteractive105517136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 3.09 KiB (0.09%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.48%. Comparing base (d27a233) to head (4b4272c).
Report is 55 commits behind head on develop.

❗ Current head 4b4272c differs from pull request most recent head 7521684. Consider uploading reports for the commit 7521684 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24433      +/-   ##
===========================================
+ Coverage    67.37%   67.48%   +0.11%     
===========================================
  Files         1278     1288      +10     
  Lines        49881    50153     +272     
  Branches     12944    13023      +79     
===========================================
+ Hits         33605    33842     +237     
- Misses       16276    16311      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [4b4272c]
Page Load Metrics (965 ± 590 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6611185157
domContentLoaded84618126
load5428139651230590
domInteractive84618126
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 3.09 KiB (0.09%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [7521684]
Page Load Metrics (873 ± 592 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6811889168
domContentLoaded9351473
load5430868731232592
domInteractive9351473
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 3.09 KiB (0.09%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@mikesposito mikesposito merged commit e3207d4 into develop May 14, 2024
71 of 72 checks passed
@mikesposito mikesposito deleted the bump-rate-limit-controller branch May 14, 2024 11:41
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
@metamaskbot metamaskbot added the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file release-11.18.0 Issue or pull request that will be included in release 11.18.0 team-shared-libraries
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants