fix: remove unused code to overwrite filenames for Sentry error reporting

[sethkfman]

Development & PR Process

1. Follow MetaMask Mobile Coding Standards
2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
3. Add needs-dev-review label when work is completed
4. Add the appropiate QA label when dev review is completed
   • needs-qa: PR requires manual QA.
   • No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.
   • Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.
5. Add QA Passed label when QA has signed off (Only required if the PR was labeled with needs-qa)

Description

This PR fixes the way we are processing Sentry errors.

• The code in question was initially pulled from work done by the extension team during the privacy work in December.
• This was added but does not seem to be providing any privacy related value and introduces a Sentry error logging bug overwriting the filename when error occurs. The context behind the code can be found in this extension PR.

Test evidence
Logging Before

    {
        "colno": null,
        "filename": "metamask-mobile",
        "function": "_onChangeTab",
        "in_app": false,
        "lineno": undefined,
        "platform": "node"
    },
   {
        "colno": 4,
        "filename": "metamask-mobile",
        "function": "createReactClass$argument_0._onChangeTab",
        "in_app": false,
        "lineno": undefined,
        "platform": "node"
    },
    {
        "colno": 17,
        "context_line": "    Logger.error(new Error(), \"Error while checking What's New modal!\");",
        "filename": "metamask-mobile",
        "function": "onChangeTab",
        "in_app": true,
        "lineno": 231,
        "platform": "javascript",
        "post_context": [
            "  }, []);",
            "",
            "  const renderContent = useCallback(() => {",
            "    let balance: any = 0;",
            "    let assets = tokens;"
        ],
        "pre_context": [
            "        Analytics.trackEvent(MetaMetricsEvents.WALLET_TOKENS);",
            "      } else {",
            "        Analytics.trackEvent(MetaMetricsEvents.WALLET_COLLECTIBLES);",
            "      }",
            "    });"
        ]
    }

Logging After

    {
        "colno": null,
        "filename": "[native code]",
        "function": "_onChangeTab",
        "in_app": false,
        "lineno": undefined,
        "platform": "node"
    },
    {
        "colno": 4,
        "filename": "app:///index.js",
        "function": "createReactClass$argument_0._onChangeTab",
        "in_app": false,
        "lineno": undefined,
        "platform": "node"
    },
    {
        "colno": 17,
        "context_line": "    Logger.error(new Error(), \"Error while checking What's New modal!\");",
        "filename": "app:///index.tsx",
        "function": "onChangeTab",
        "in_app": true,
        "lineno": 231,
        "platform": "javascript",
        "post_context": [
            "  }, []);",
            "",
            "  const renderContent = useCallback(() => {",
            "    let balance: any = 0;",
            "    let assets = tokens;"
        ],
        "pre_context": [
            "        Analytics.trackEvent(MetaMetricsEvents.WALLET_TOKENS);",
            "      } else {",
            "        Analytics.trackEvent(MetaMetricsEvents.WALLET_COLLECTIBLES);",
            "      }",
            "    });"
        ]
    }

Issue

NA

Checklist

• [NA] There is a related GitHub issue
• Tests are included if applicable
• Any added code is fully documented

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sethkfman]

@Gudahtt I have completed removed the function since the purpose of it was to enable a single sourcemap on extension and mobile does not have that configuration. The function does not impact privacy.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

[Gudahtt]

LGTM!