Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update signature controller v13 #9625

Merged
merged 6 commits into from
May 16, 2024

Conversation

MarioAslau
Copy link
Contributor

Description

  • Update Signature Controller to v^13
  • Changelog here

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@MarioAslau MarioAslau requested a review from a team as a code owner May 14, 2024 18:54
@MarioAslau MarioAslau self-assigned this May 14, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@MarioAslau MarioAslau added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels May 14, 2024
@MarioAslau MarioAslau requested a review from tommasini May 14, 2024 18:54
Copy link

socket-security bot commented May 14, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/signature-controller@13.0.0 Transitive: filesystem, network +14 3.26 MB metamaskbot

🚮 Removed packages: npm/@metamask/signature-controller@6.1.3

View full report↗︎

@legobeat legobeat added the Run Smoke E2E Triggers smoke e2e on Bitrise label May 15, 2024
Copy link
Contributor

github-actions bot commented May 15, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cc96a60
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/17b5988f-d1af-4152-b36a-f1ffc46c30b8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.42%. Comparing base (220d717) to head (cc96a60).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9625      +/-   ##
==========================================
+ Coverage   46.27%   46.42%   +0.14%     
==========================================
  Files        1336     1340       +4     
  Lines       32582    32574       -8     
  Branches     3445     3483      +38     
==========================================
+ Hits        15076    15121      +45     
+ Misses      16594    16520      -74     
- Partials      912      933      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarioAslau MarioAslau removed the Run Smoke E2E Triggers smoke e2e on Bitrise label May 15, 2024
Copy link

socket-security bot commented May 15, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@MarioAslau MarioAslau merged commit c096260 into main May 16, 2024
31 checks passed
@MarioAslau MarioAslau deleted the feat/update-signature-controllerv13 branch May 16, 2024 10:59
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 16, 2024
@metamaskbot metamaskbot added the release-7.24.0 Issue or pull request that will be included in release 7.24.0 label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.24.0 Issue or pull request that will be included in release 7.24.0 team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants