refactor(network): Rename 'Base Mainnet' to 'Base' #9631
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates 'Base Mainnet' to 'Base'
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9631 +/- ##
==========================================
+ Coverage 46.27% 46.42% +0.14%
==========================================
Files 1336 1340 +4
Lines 32582 32574 -8
Branches 3445 3483 +38
==========================================
+ Hits 15076 15121 +45
+ Misses 16594 16520 -74
- Partials 912 933 +21 ☔ View full report in Codecov by Sentry. |
sahar-fehri
added a commit
that referenced
this pull request
May 28, 2024
## **Description** PR to update base nickname from Base Mainnet to Base. ## **Related issues** Fixes: Relates to: #9631 ## **Manual testing steps** 1. Go to Settings => Networks => Add Network 2. You should be able to see the Name `Base` and add the network. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** https://github.com/MetaMask/metamask-mobile/assets/10994169/ba3e506e-8603-482b-8df6-2d1fd8c21984 ### **After** https://github.com/MetaMask/metamask-mobile/assets/10994169/8838d2c2-d932-4a37-aa7c-86f71cd9a274 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates 'Base Mainnet' to 'Base'
Related issues
N/A
Manual testing steps
N/A
Screenshots/Recordings
N/A
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist