Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump SES #9637

Merged
merged 2 commits into from
May 29, 2024
Merged

chore: bump SES #9637

merged 2 commits into from
May 29, 2024

Conversation

leotm
Copy link
Contributor

@leotm leotm commented May 15, 2024

Description

  • bump SES to v1.5.0
  • includes Hermes fix in preparation for Hermes SES shim

Related issues

Manual testing steps

Run: curl -O https://npmfs.com/download/ses/1.5.0/dist/ses.cjs
Result: no change/diff

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@leotm leotm added dependencies Pull requests that update a dependency file team-security Run Smoke E2E Triggers smoke e2e on Bitrise labels May 15, 2024
@leotm leotm requested a review from legobeat May 15, 2024 18:20
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2896113
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/429ee5f8-d254-4eef-8e49-d7625e607fb9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@leotm leotm marked this pull request as ready for review May 20, 2024 11:30
@leotm leotm requested a review from a team as a code owner May 20, 2024 11:30
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 20, 2024
@legobeat legobeat requested a review from a team May 20, 2024 11:37
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 20, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a7d6022
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/efa6f46a-4f03-4b20-a4d1-5a1d58b333c4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@leotm leotm merged commit 9ce8b86 into main May 29, 2024
33 checks passed
@leotm leotm deleted the chore-bump-ses branch May 29, 2024 10:48
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
@metamaskbot metamaskbot added the release-7.24.0 Issue or pull request that will be included in release 7.24.0 label May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@legobeat legobeat legobeat approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file release-7.24.0 Issue or pull request that will be included in release 7.24.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leotm @legobeat @metamaskbot