Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update base controller v5, logging controller v3, permission controll… #9640

Merged
merged 8 commits into from
May 22, 2024
Merged

chore: Update base controller v5, logging controller v3, permission controll… #9640

merged 8 commits into from
May 22, 2024

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented May 15, 2024 •
edited

Description

Update:

  • base controller v^5
  • logging controller v^3
  • permission controller v^9
  • phishing controller v^9
  • network controllver v^18

Addressed ts errors on engine file.
Added ts expect errors for the controllers that need to be updated due to base controller version mismatch.
Fix ts issue on rpc method middleware.

Related issues

Fixes:

Manual testing steps

  1. Test Permissions with dapps (Connect multiple accounts, and different accounts per dapp, and make sure the wallet have it's own account connected)
  2. Test Networks (Change network on wallet view, add and remove from popular list, add custom network, add network via dapp)
  3. Test phishing websites (neomecolife.com)

Screenshots/Recordings

Permissions testing:
https://github.com/MetaMask/metamask-mobile/assets/46944231/be1636be-a35c-427e-9dc2-c2bdcbcd445c

Networks testing:
https://github.com/MetaMask/metamask-mobile/assets/46944231/2412e8b4-ea01-4d23-96a7-9262176ba8cf

Phishing website testing:
https://github.com/MetaMask/metamask-mobile/assets/46944231/a70c07e0-5852-49ea-9676-87b1a57b8613

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini
Update base controller v5, logging controller v3, permission controll…
99012a0 
…er v9, phishing controller v9, addressed ts errors on engine file and added ts expect errors for the controllers that need to be updated due to base controller version mismatch, also fix ts issue on rpcmethod middle ware
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security Socket Security
Copy link

socket-security bot commented May 15, 2024 •
edited

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/logging-controller@3.0.1 Transitive: filesystem, network +6 2.08 MB metamaskbot
npm/@metamask/permission-controller@9.0.2 Transitive: filesystem +7 2.48 MB metamaskbot
npm/@metamask/phishing-controller@9.0.2 network Transitive: filesystem +6 1.94 MB metamaskbot

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented May 15, 2024 •
edited

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@tommasini tommasini added the Run Smoke E2E Triggers smoke e2e on Bitrise label May 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3b93d7b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/db91f330-f88d-403d-9df6-a7836eacf4aa

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 17, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 456816b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2d4719d1-a3e0-4e2f-90ed-03c2d3f93b7f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini marked this pull request as ready for review May 17, 2024 18:48
@tommasini tommasini requested a review from a team as a code owner May 17, 2024 18:48
@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 17, 2024
@MarioAslau MarioAslau added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 22, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8a8da92
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/675963b7-537e-4e49-a273-475de45ff08a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

MarioAslau
MarioAslau approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tommasini tommasini merged commit e6ca593 into main May 22, 2024
35 checks passed
@tommasini tommasini deleted the update/1781-base-controller-v5 branch May 22, 2024 13:22
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
@metamaskbot metamaskbot added the release-7.24.0 Issue or pull request that will be included in release 7.24.0 label May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarioAslau MarioAslau MarioAslau approved these changes

Assignees
No one assigned
Labels
release-7.24.0 Issue or pull request that will be included in release 7.24.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tommasini @MarioAslau @metamaskbot