devDeps: bump vite and webdriverio #2121

legobeat · 2024-01-22T14:56:19Z

Bump vite from 4.4 to 4.5.
- Closes:
  - GHSA-c24v-8rfc-w8vw / GHSA-c24v-8rfc-w8vw
  - GHSA-92r3-m2mg-pj97 / GHSA-92r3-m2mg-pj97
Bump vite-tsconfig-paths@^4.0.5->^4.3.1
Bump @wdio/* from ^8.19.0 to ^8.28.0
- Removes transitive dependency on vite@~4.4.6 - deduping it

socket-security · 2024-01-22T14:57:45Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@ljharb/through@2.3.11	Transitive: eval	`+4`	140 kB	ljharb
npm/@vitest/spy@1.2.1	None	`+1`	31.6 kB	oreanno
npm/@wdio/browser-runner@8.28.8	Transitive: environment, eval, filesystem, network, shell, unsafe	`+461`	886 MB	wdio-user
npm/@wdio/cli@8.28.8	environment Transitive: eval, filesystem, network, shell, unsafe	`+324`	68.7 MB	wdio-user
npm/@wdio/local-runner@8.28.8	Transitive: environment, eval, filesystem, network, shell, unsafe	`+252`	65.3 MB	wdio-user
npm/@wdio/mocha-framework@8.28.8	Transitive: environment, eval, filesystem, network, shell	`+152`	53 MB	wdio-user
npm/@wdio/reporter@8.28.6	None	`+7`	941 kB	wdio-user
npm/@wdio/runner@8.28.8	Transitive: environment, eval, filesystem, network, shell, unsafe	`+248`	61.2 MB	wdio-user
npm/@wdio/spec-reporter@8.28.8	None	`+14`	1.05 MB	wdio-user
npm/@wdio/static-server-service@8.28.6	Transitive: environment, eval, filesystem, network, unsafe	`+61`	2.38 MB	wdio-user
npm/inquirer@9.2.12	Transitive: environment, eval, filesystem, shell	`+46`	5.67 MB	sboudrias
npm/safe-stringify@1.1.0	None	`0`	4.49 kB	sindresorhus
npm/tinyspy@2.2.0	None	`0`	13.6 kB	oreanno
npm/tsconfck@3.0.1	None	`+1`	68.8 MB	dominik_g
npm/vite-tsconfig-paths@4.3.1	filesystem Transitive: environment, eval, network, shell, unsafe	`+43`	287 MB	aleclarson
npm/vite@4.5.2	environment, eval, filesystem, network, shell, unsafe	`+38`	218 MB	vitebot

🚮 Removed packages: npm/@ljharb/through@2.3.9, npm/@wdio/browser-runner@8.19.0, npm/@wdio/cli@8.19.0, npm/@wdio/config@8.19.0, npm/@wdio/globals@8.19.0, npm/@wdio/local-runner@8.19.0, npm/@wdio/mocha-framework@8.19.0, npm/@wdio/protocols@8.18.0, npm/@wdio/repl@8.10.1, npm/@wdio/reporter@8.19.0, npm/@wdio/runner@8.19.0, npm/@wdio/spec-reporter@8.19.0, npm/@wdio/static-server-service@8.19.0, npm/@wdio/types@8.19.0, npm/@wdio/utils@8.19.0, npm/cac@3.0.4, npm/camelcase-keys@3.0.0, npm/find-up@1.1.2, npm/has-ansi@2.0.0, npm/import-meta-resolve@3.1.1, npm/inquirer@9.2.11, npm/is-utf8@0.2.1, npm/load-json-file@1.1.0, npm/map-obj@1.0.1, npm/pinkie-promise@2.0.1, npm/pinkie@2.0.4, npm/suffix@0.1.1, npm/tinyspy@2.1.1, npm/tsconfck@2.0.2, npm/vite-tsconfig-paths@4.0.5, npm/vite@4.4.12, npm/webdriver@8.19.0, npm/webdriverio@8.19.0, npm/yarn-install@1.0.0

View full report↗︎

socket-security · 2024-01-22T14:57:51Z

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note
No contributors or author data	npm/@vitest/spy@1.2.1	Location: Package overview
New author	npm/safe-stringify@1.1.0	New Author: sindresorhus Previous Author: nedrocks

View full report↗︎

Next steps

Why is contributor and author data important?

Package does not specify a list of contributors or an author in package.json.

Add a author field or contributors array to package.json.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@SocketSecurity ignore npm/@vitest/spy@1.2.1
@SocketSecurity ignore npm/safe-stringify@1.1.0

codecov · 2024-01-22T15:02:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf1fa9a) 96.66% compared to head (246822f) 96.66%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2121   +/-   ##
=======================================
  Coverage   96.66%   96.66%           
=======================================
  Files         312      312           
  Lines        7042     7042           
  Branches     1104     1104           
=======================================
  Hits         6807     6807           
  Misses        235      235

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Mrtenz

Looks good to me, but there's a lot of lint errors currently:
https://github.com/MetaMask/snaps/actions/runs/7613049917/job/20732121835?pr=2121

- Closes: - CVE-2024-23331 / GHSA-c24v-8rfc-w8vw - CVE-2023-49293 / GHSA-92r3-m2mg-pj97 - Bump vite-tsconfig-paths@^4.0.5->^4.3.1

- remove dependency on vite ~4.4.6

FrederikBolding · 2024-01-22T15:32:54Z

Looks good to me, but there's a lot of lint errors currently: https://github.com/MetaMask/snaps/actions/runs/7613049917/job/20732121835?pr=2121

Looks like the linter thinks we should await expectations in WDIO now 🤔 Did the API change without a major version bump? 🤔

legobeat · 2024-01-23T15:05:41Z

Looks good to me, but there's a lot of lint errors currently: https://github.com/MetaMask/snaps/actions/runs/7613049917/job/20732121835?pr=2121

Looks like the linter thinks we should await expectations in WDIO now 🤔 Did the API change without a major version bump? 🤔

@FrederikBolding : I see the errors crop up down to wdio 8.20. It turns out that on current snaps main and for older wdio versions, expect is typed as jest.Expect, whereas it now has a type that involves a Promise (<Record<string, unknown>, void | Promise<void>>(actual: Record<string, unknown>) => ExpectWebdriverIO.Matchers<void | Promise<void>, Record<string, unknown>>).

Haven't actually tracked down where that change is introduced, yet.

(see action results for each commit for reference: legobeat#10)

@wdio/browser-runner uses updated vite starting with v8.21.0.

FrederikBolding · 2024-01-31T12:17:38Z

This seems related: webdriverio/webdriverio#11999

legobeat added type-security Related to enforcing our security model. dependencies Pull requests that update a dependency file labels Jan 22, 2024

Mrtenz reviewed Jan 22, 2024

View reviewed changes

legobeat marked this pull request as ready for review January 22, 2024 15:28

legobeat requested a review from a team as a code owner January 22, 2024 15:28

legobeat added 2 commits January 23, 2024 00:28

devDeps: vite@^4.3.9->^4.5.2

2d69d1d

- Closes: - CVE-2024-23331 / GHSA-c24v-8rfc-w8vw - CVE-2023-49293 / GHSA-92r3-m2mg-pj97 - Bump vite-tsconfig-paths@^4.0.5->^4.3.1

fix(devDeps): @wdio/*@^8.19.0->^8.28.0

246822f

- remove dependency on vite ~4.4.6

legobeat force-pushed the deps-vite branch from 77c33bd to 246822f Compare January 22, 2024 15:28

legobeat marked this pull request as draft January 22, 2024 15:28

This comment was marked as resolved.

Sign in to view

FrederikBolding mentioned this pull request May 23, 2024

Update Chromedriver #2429

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

devDeps: bump vite and webdriverio #2121

devDeps: bump vite and webdriverio #2121

legobeat commented Jan 22, 2024

socket-security bot commented Jan 22, 2024 •

edited

socket-security bot commented Jan 22, 2024 •

edited

codecov bot commented Jan 22, 2024 •

edited

Mrtenz left a comment

FrederikBolding commented Jan 22, 2024

This comment was marked as resolved.

legobeat commented Jan 23, 2024 •

edited

FrederikBolding commented Jan 31, 2024

devDeps: bump vite and webdriverio #2121

Are you sure you want to change the base?

devDeps: bump vite and webdriverio #2121

Conversation

legobeat commented Jan 22, 2024

socket-security bot commented Jan 22, 2024 • edited

socket-security bot commented Jan 22, 2024 • edited

Next steps

codecov bot commented Jan 22, 2024 • edited

Codecov Report

Mrtenz left a comment

Choose a reason for hiding this comment

FrederikBolding commented Jan 22, 2024

This comment was marked as resolved.

legobeat commented Jan 23, 2024 • edited

FrederikBolding commented Jan 31, 2024

socket-security bot commented Jan 22, 2024 •

edited

socket-security bot commented Jan 22, 2024 •

edited

codecov bot commented Jan 22, 2024 •

edited

legobeat commented Jan 23, 2024 •

edited