Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snaps-jest docs #2181

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update snaps-jest docs #2181

wants to merge 2 commits into from

Conversation

ziad-saab
Copy link
Contributor

@ziad-saab ziad-saab commented Feb 9, 2024

  • More descriptive names for tests
  • Remove parameters to snap.onHomepage
  • Remove references to executionEnvironmentUrl and simulatorUrl

@ziad-saab ziad-saab requested a review from a team as a code owner February 9, 2024 16:57
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (01829d3) 96.54% compared to head (b7a9502) 96.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2181   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files         331      331           
  Lines        7463     7463           
  Branches     1146     1146           
=======================================
  Hits         7205     7205           
  Misses        258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

you want to use your own HTTP server, you can disable this option, and use the
`executionEnvironmentUrl` and `simulatorUrl` options to configure the URLs of
your own server.
you want to use your own HTTP server, you can disable this option, and use [`installSnap`](#install-a-snap) with a custom server, e.g. `installSnap('local:http://my-server')`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
you want to use your own HTTP server, you can disable this option, and use [`installSnap`](#install-a-snap) with a custom server, e.g. `installSnap('local:http://my-server')`.
you want to use your own HTTP server, you can disable this option, and use
[`installSnap`](#install-a-snap) with a custom server, e.g.,
`installSnap('local:http://my-server')`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants