Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lavamoat/webpack setup #2241

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

lavamoat/webpack setup #2241

wants to merge 5 commits into from

Conversation

naugtur
Copy link

@naugtur naugtur commented Mar 4, 2024

Policy generation works with no quirks to pave over with overrides.
Project successfully builds.
lockdown inlining solved with html-webpack-plugin itself. There's room for improvement, but it's pretty simple as is.
I did not remove the pre-existing browserify build.

Using typescript for weback config is not ideal, because it's a common problem that depending on how your dependencies arrange/dedupe you may get type mismatches between your webpack version and plugins. This problem will start manifesting itself once we publish types for the plugin. As soon as the version of webpack we take types from differs from the version used in the repo, we're risking a mismatch of the webpack plugin type (even for minor changes)

@naugtur naugtur marked this pull request as ready for review March 28, 2024 14:36
@naugtur naugtur requested a review from a team as a code owner March 28, 2024 14:36
@naugtur naugtur changed the title WIP lavamoat/webpack setup lavamoat/webpack setup Mar 28, 2024
Copy link

socket-security bot commented Mar 28, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/opener@1.5.2, npm/webpack-bundle-analyzer@4.10.1

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@naugtur
Copy link
Author

naugtur commented Mar 28, 2024

@SocketSecurity ignore npm/webpack-bundle-analyzer@4.10.1 - uses http for local server
@SocketSecurity ignore npm/opener@1.5.2 - the whole purpose of the package is running child processes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants