Format changelogs with Prettier #2391
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
commented
May 3, 2024
|
|
||
| if [[ "${GITHUB_REF:-}" =~ '^release/' ]]; then | ||
| yarn auto-changelog validate --tag-prefix "${package_name}@" --rc | ||
| yarn auto-changelog validate --prettier --tag-prefix "${package_name}@" --rc "$@" |
There was a problem hiding this comment.
The "$@" allows us to run this script with --fix.
Mrtenz
force-pushed
the
mrtenz/prettier-changelogs
branch
from
fa944ba
to
7f40614
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2391 +/- ##
=======================================
Coverage 94.32% 94.32%
=======================================
Files 438 438
Lines 9021 9021
Branches 1382 1382
=======================================
Hits 8509 8509
Misses 512 512 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our release workflow assumes we use Prettier for changelogs, so we had to manually fix them when creating a release. I've updated our validation to use Prettier for changelog formatting, and updated all changelogs.