Update to mocha 4.x

[SimonSimCity]

@aldeed or anyone else with knowledge about building a package:

Could you please help me updating this library to mocha v4.x?

The problem I'm facing only shows itself when running the client-tests using PhantomJS.

After setting the mocha version to 4.0.0 I get the following output for my client-tests on PhantomJS:

[[[[[ Tests ]]]]]                             

=> Started proxy.                             
=> Started MongoDB.                           
Kadira: Successfully connected                
SKIPPING SERVER TESTS BECAUSE TEST_SERVER=0

--------------------------------
----- RUNNING CLIENT TESTS -----
--------------------------------
Kadira: completed instrumenting the app
=> Started your app.

=> App running at: http://localhost:3100/
Error: Cannot find module 'meteor/meteortesting:mocha-core'

  phantomjs://code/phantomjs_script.js:15 in onError
    http://localhost:3100/packages/modules-runtime.js?hash=9f9bb5e055614ddf4eb3e743737b7a5b3cfd9d34: 261

  phantomjs://code/phantomjs_script.js:17
    http://localhost:3100/packages/meteortesting_mocha.js?hash=ae610fb44d725619cd8fa50f6488713b2a110b0c: 38

  phantomjs://code/phantomjs_script.js:17
    http://localhost:3100/packages/modules-runtime.js?hash=9f9bb5e055614ddf4eb3e743737b7a5b3cfd9d34: 353

  phantomjs://code/phantomjs_script.js:17
    http://localhost:3100/packages/modules-runtime.js?hash=9f9bb5e055614ddf4eb3e743737b7a5b3cfd9d34: 248

  phantomjs://code/phantomjs_script.js:17
    http://localhost:3100/packages/meteortesting_mocha.js?hash=ae610fb44d725619cd8fa50f6488713b2a110b0c: 345

  phantomjs://code/phantomjs_script.js:17
ReferenceError: Can't find variable: describe

  phantomjs://code/phantomjs_script.js:15 in onError
    http://localhost:3100/app/app.js?hash=de05b23aace387f33c6d47f542e110f93b48a4cd: 257

  phantomjs://code/phantomjs_script.js:17
    http://localhost:3100/packages/modules-runtime.js?hash=9f9bb5e055614ddf4eb3e743737b7a5b3cfd9d34: 353

  phantomjs://code/phantomjs_script.js:17
    http://localhost:3100/packages/modules-runtime.js?hash=9f9bb5e055614ddf4eb3e743737b7a5b3cfd9d34: 248

  phantomjs://code/phantomjs_script.js:17
Error: Can't find test driver package: meteortesting:mocha

  phantomjs://code/phantomjs_script.js:15 in onError
    http://localhost:3100/packages/meteor.js?hash=c9a34f92f28ede5a42eac467d3fa1763b624436a: 1081

  phantomjs://code/phantomjs_script.js:17
    http://localhost:3100/packages/meteor.js?hash=c9a34f92f28ede5a42eac467d3fa1763b624436a: 871

  phantomjs://code/phantomjs_script.js:17
    http://localhost:3100/packages/meteor.js?hash=c9a34f92f28ede5a42eac467d3fa1763b624436a: 883

  phantomjs://code/phantomjs_script.js:17

I can confirm that all the client-tests run through in Chrome, so I guess it has something to do with PhantomJS. Another reason could be that phantom is a browser, completely written in JavaScript, so I don't know if it has something there that accidentally get's in there.

The version 4.x has some breaking changes - a.o. also removed the support for Bower, where they also mention webpack. Could it have something to do with this? https://boneskull.com/mocha-v4-nears-release/#mochawillnolongersupportbower

I'm currently just picking in the dust and have not really an idea what the reason could be. Would you have time to take a look at it?

My personal motivation is to get mochajs/mocha#2095 included, which got merged in 4.0.0. Because of this I currently sometimes see the results of my test-reports cut in half. I can explain it in another bug-report if requested.

[SimonSimCity]

I'm not a medic, but it doesn't look well for PhantomJS. ariya/phantomjs#14541 where the project-owner asked for help, followed by ariya/phantomjs#15345 where someone tried to cut him off (sad story, really!) and lately ariya/phantomjs#15344 ...

[SimonSimCity]

The project https://github.com/ariya/phantomjs has been archived and it's future development sealed - if not any of the branches suddenly will stick out and take the lead of development. I've decided to treat it as an outdated browser which this plugin won't support anymore.